[secp256k1] Support inputed compressed public keys #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
force-pushed
the
secp256k1-compressed
branch
from
aec7010
to
6207704
Compare
gregnazario
changed the title
gregnazario
force-pushed
the
secp256k1-compressed
branch
from
6207704
to
90d58dc
Compare
gregnazario
force-pushed
the
secp256k1-compressed
branch
from
90d58dc
to
8b7ad29
Compare
0xmaayan
approved these changes
Nov 25, 2024
GhostWalker562
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support compressed public keys for secp256k1 natively in the SDK.
Looks like originally it only supported uncompressed keys, which may not be given to users.
Test Plan
Check out the new test for how we test compression.
Related Links
Checklist
pnpm fmt?CHANGELOG.md?