Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cad instructions #578

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Update cad instructions #578

merged 2 commits into from
Sep 4, 2024

Conversation

0xaptosj
Copy link
Contributor

@0xaptosj 0xaptosj commented Aug 30, 2024

Description

Move collection address and fa address from config.ts to .env.
CAD PR aptos-labs/create-aptos-dapp#195

Checklist

  • Do all Lints pass?
    • Have you ran pnpm spellcheck?
    • Have you ran pnpm fmt?
    • Have you ran pnpm lint?

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 4:43pm

Copy link
Contributor

@0xmaayan 0xmaayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait with merge until a new CAD version is out https://github.com/aptos-labs/create-aptos-dapp/blob/main/CHANGELOG.md#unreleased

Blocking just to be on the safe side

@0xaptosj 0xaptosj merged commit 7dec28f into main Sep 4, 2024
5 checks passed
@0xaptosj 0xaptosj deleted the j/update-cad-5 branch September 4, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants