fix(test): use default undername count in records test

ar-io · Aug 22, 2023 · cedbfa1 · cedbfa1
1 parent 2d92f5b
commit cedbfa1
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/schemas/index.js b/schemas/index.js
@@ -1,6 +1,7 @@
 const { buyRecordSchema } = require('./buyRecord');
 const { auctionBidSchema } = require('./auction');
 const { increaseUndernameCountSchema } = require('./undernames');
+
 module.exports = {
   auctionBidSchema,
   buyRecordSchema,

diff --git a/schemas/undernames.js b/schemas/undernames.js
@@ -1,5 +1,3 @@
-const { MAX_ALLOWED_UNDERNAMES, DEFAULT_UNDERNAME_COUNT } = require("../src/constants");
-
 const increaseUndernameCountSchema = {
   $id: '#/definitions/increaseUndernameCount',
   type: 'object',
@@ -15,7 +13,7 @@ const increaseUndernameCountSchema = {
     qty: {
       type: 'number',
       minimum: 1,
-      maximum: MAX_ALLOWED_UNDERNAMES - DEFAULT_UNDERNAME_COUNT
+      maximum: 9990, // should be updated with contants "DEFAULT_UNDERNAME_COUNT" and "MAX_ALLOWED_UNDERNAMES"
     },
   },
   required: ['name', 'qty'],

diff --git a/src/constants.ts b/src/constants.ts
@@ -28,7 +28,7 @@ export const PERMABUY_LEASE_FEE_LENGTH = 10;
 export const ALLOWED_ACTIVE_TIERS = [1, 2, 3];
 export const ANNUAL_PERCENTAGE_FEE = 0.1; // 10% of cost of name
 export const DEFAULT_UNDERNAME_COUNT = 10;
-export const MAX_ALLOWED_UNDERNAMES = 10_000;
+export const MAX_ALLOWED_UNDERNAMES = 10_000; // when modifying these, update the undernames schema
 export const UNDERNAME_REGISTRATION_IO_FEE = 1; // 1 IO token per undername
 export const NON_CONTRACT_OWNER_MESSAGE = `Caller is not the owner of the ArNS!`;
 export const INVALID_ARNS_NAME_MESSAGE = 'Invalid ArNS Record Name';

diff --git a/tests/records.test.ts b/tests/records.test.ts
@@ -5,6 +5,7 @@ import { arweave, warp } from './setup.jest';
 import {
   ANT_CONTRACT_IDS,
   ARNS_NAME_RESERVED_MESSAGE,
+  DEFAULT_UNDERNAME_COUNT,
   INVALID_INPUT_MESSAGE,
   INVALID_SHORT_NAME,
   INVALID_TIER_MESSAGE,
@@ -62,7 +63,7 @@ describe('Records', () => {
         endTimestamp: expect.any(Number),
         startTimestamp: expect.any(Number),
         contractTxID: expect.any(String),
-        undernames: expect.any(Number),
+        undernames: DEFAULT_UNDERNAME_COUNT,
       };
       expect(record).not.toBe(undefined);
       expect(record).toEqual(expectObjected);
@@ -120,7 +121,7 @@ describe('Records', () => {
         tier: tiers.current[0],
         endTimestamp: expect.any(Number),
         startTimestamp: expect.any(Number),
-        undernames: expect.any(Number),
+        undernames: DEFAULT_UNDERNAME_COUNT,
         type: 'lease',
       });
       expect(balances[nonContractOwnerAddress]).toEqual(
@@ -170,7 +171,7 @@ describe('Records', () => {
         tier: tiers.current[0],
         endTimestamp: expect.any(Number),
         startTimestamp: expect.any(Number),
-        undernames: expect.any(Number),
+        undernames: DEFAULT_UNDERNAME_COUNT,
         type: 'lease',
       });
       expect(balances[nonContractOwnerAddress]).toEqual(
@@ -220,7 +221,7 @@ describe('Records', () => {
         tier: tiers.current[0],
         type: 'permabuy',
         startTimestamp: expect.any(Number),
-        undernames: expect.any(Number),
+        undernames: DEFAULT_UNDERNAME_COUNT,
       });
       expect(balances[nonContractOwnerAddress]).toEqual(
         prevBalance - expectedPurchasePrice,
@@ -752,7 +753,7 @@ describe('Records', () => {
         tier: tiers.current[0],
         endTimestamp: expect.any(Number),
         startTimestamp: expect.any(Number),
-        undernames: expect.any(Number),
+        undernames: DEFAULT_UNDERNAME_COUNT,
         type: 'lease',
       });
       expect(cachedValue.errorMessages[writeInteraction!.originalTxId]).toBe(