Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Tensorboard Support #32

Open
araffin opened this issue Oct 15, 2018 · 1 comment
Open

[Feature Request] Tensorboard Support #32

araffin opened this issue Oct 15, 2018 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@araffin
Copy link
Owner

araffin commented Oct 15, 2018

As stable-baselines has now integrated tensorflow support, that could be cool to enable it in the toolbox repo (and to add it to the pytorch RL algo: SAC, CMA-ES, ARS).

@araffin araffin added enhancement New feature or request help wanted Extra attention is needed labels Oct 15, 2018
@huiwenzhang
Copy link

huiwenzhang commented Jun 28, 2019

Hi,
To support tensorboard in stable-baselines, we need to define a tb log location for the RL agent. In this repo, arguments of the RL agent are defined by the train_kwargs, see here

algo.train(args, callback, env_kwargs=env_kwargs, train_kwargs=hyperparams)

However, the train_kwargs only accept hyper-parameters of the specific rl agent. Alternatively, we can set the log args in the 'train' method of the agent, take ppo2 as an example,
param_kwargs = {
"verbose": 1,
"n_steps": 128,
"ent_coef": 0.01,
"learning_rate": lambda f: f * 2.5e-4,
"vf_coef": 0.5,
"max_grad_norm": 0.5,
"gamma": 0.99,
"lam": 0.95,
"nminibatches": 4,

But it would be better to define the arg outside the specific agent, for example, the train file. So some small modifications may be done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants