Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track the final bundle size #49

Open
bpierre opened this issue Jun 17, 2020 · 4 comments
Open

Track the final bundle size #49

bpierre opened this issue Jun 17, 2020 · 4 comments

Comments

@bpierre
Copy link
Contributor

bpierre commented Jun 17, 2020

We should keep track of the final bundle size when the required modules are being imported in a web app.

We could have the following:

  • One bundle with only @aragon/connect.
  • One bundle with @aragon/connect + app connector, for every core app.
  • One bundle with @aragon/connect + all the core app connectors.

We could try to do this using https://bundlewatch.io/

@eliobricenov eliobricenov self-assigned this Feb 26, 2021
@eliobricenov
Copy link

Hey @bpierre, just to make sure:

One bundle with @aragon/connect + app connector, for every core app.

That would be @aragon/connect + @aragon/connect-finance + @aragon/connect-tokens + @aragon/connect-voting right?

One bundle with @aragon/connect + all the core app connectors.

And this @aragon/connect + @aragon/connect-react + @aragon/connect-core + @aragon/connect-ethereum +
@aragon/connect-thegraph?

@bpierre
Copy link
Contributor Author

bpierre commented Feb 26, 2021

That would be @aragon/connect + @aragon/connect-finance + @aragon/connect-tokens + @aragon/connect-voting right?

No it would be separate bundles, one per app connector, to test realistic final bundle sizes independently:

  • One with @aragon/connect + @aragon/connect-finance
  • One with @aragon/connect + @aragon/connect-tokens
  • One with @aragon/connect + @aragon/connect-voting
  • One with @aragon/connect + @aragon/connect-disputable-voting
  • One with @aragon/connect + @aragon/connect-agreement

One bundle with @aragon/connect + all the core app connectors.

And this @aragon/connect + @aragon/connect-react + @aragon/connect-core + @aragon/connect-ethereum +
@aragon/connect-thegraph?

It would be a single app using most of the app connectors, to keep track of a bundle size when using a lot of app connectors at once.

For example, the bundle could contain the following:

  • @aragon/connect
  • @aragon/connect-finance
  • @aragon/connect-tokens
  • @aragon/connect-voting
  • @aragon/connect-agreement

@eliobricenov
Copy link

Ok, that makes sense, thanks @bpierre

@eliobricenov
Copy link

eliobricenov commented Mar 1, 2021

I did some research and https://bundlewatch.io/ would be useful to track single file sizes (e.g React's final .js files) but in order to check different combinations of packages, we'd need to track directory sizes instead.

Maybe we can use their NodeJS API to implement a solution, either way, I can do further research on other options as well.

That being said, I think that given that this is an enhancement, bug's issues such as aragon/aragon-cli#1082 have a higher priority and should be tackled first.

What do you think? @nivida

@eliobricenov eliobricenov removed their assignment Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants