Refactor build workflow #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
approved these changes
Jun 10, 2024
Weird: I guess I clicked wrong on the warning dialog. (It's a draft, now.... 🙂) |
jaredoconnell
approved these changes
Jun 10, 2024
|
Marking this ready for review (although, it already has two approvals). We just need to see the CI run...but neither making it ready for review nor posting this comment triggered the CI (which, maybe, is good?). So, I tweaked the commit message and force-pushed the branch to trigger the run. |
- Use reusable workflows for linting, testing, and 'go generate'. - Rename the workflow file to .yaml to be consistent with other repos.
|
Aaaaand, we're back to draft mode while I figure out how to deal with the fact that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
This PR refactors the
build.yamlGitHub workflow:.github/scripts/gogenerate.shto thearcaflow-reusable-workflowsrepo;go generate;.yamlto be consistent with other repos;v*tags;ARCALOT_GO_VERSIONinstead of hard-coding it.Note: this PR depends on arcalot/arcaflow-reusable-workflows#21, so the CI won't run until that PR is merged (until such time, this PR will be a draft).
By contributing to this repository, I agree to the contribution guidelines.