Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review - Please remove this from code #390

Open
ondra-novak opened this issue Oct 29, 2024 · 0 comments
Open

Code Review - Please remove this from code #390

ondra-novak opened this issue Oct 29, 2024 · 0 comments
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@ondra-novak
Copy link

This should be removed from code. Don't mix macros and C++. This code cannot pass my internal code review check.

ArduinoCore-renesas/libraries/Arduino_LED_Matrix/src/Arduino_LED_Matrix.h

Line 144 in 1169821

#define loadSequence(frames) loadWrapper(frames, sizeof(frames))

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@per1234 @ondra-novak