Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getTime function to WiFiS3 library #271

Closed
wants to merge 5 commits into from
Closed

Add getTime function to WiFiS3 library #271

wants to merge 5 commits into from

Conversation

paulvha
Copy link
Contributor

@paulvha paulvha commented Feb 21, 2024 •
edited by per1234
Loading

This requires a change in the bridge firmware as well: arduino/uno-r4-wifi-usb-bridge#48. In commands.h it MUST have:

#define _GETTIME                 "+GETTIME"

Fixes #206

@paulvha paulvha changed the title Gettime WIFIS3 Gettime issue 206 Feb 21, 2024
@per1234 per1234 linked an issue Feb 21, 2024 that may be closed by this pull request
WiFi.getTime() function on WiFiS3 library doesn't work #206
Closed
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Feb 21, 2024
@paulvha
Copy link
Contributor Author

paulvha commented Feb 22, 2024 •
edited by per1234
Loading

It does not compile as it needs _GETTIME to be defined in the WiFiCommands.h.

That file however is a symbolic link to ../../../extras/uno-r4-wifi-usb-bridge/UNOR4USBBridge/commands.h

The uno-r4-wifi-usb-bridge is a git-module that needs to be loaded BUT it first needs commands.h to be updated. A separate pull-request has been sent for that to uno-r4-wifi-usb-bridge:
arduino/uno-r4-wifi-usb-bridge#48

please advice how to do this different

regards
Paul

@per1234 per1234 changed the title WIFIS3 Gettime issue 206 Add getTime function to WiFiS3 library Mar 5, 2024
@pennam
Copy link
Contributor

pennam commented Nov 21, 2024

superseded by #394

@pennam pennam closed this Nov 21, 2024
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WiFi.getTime() function on WiFiS3 library doesn't work
3 participants
@paulvha @pennam @per1234