Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore support of breadcrumbs.enabled, window.titleBarStyle, and workbench.editor.highlightModifiedTabs advanced settings #1733

Open
3 tasks done
kittaakos opened this issue Dec 1, 2022 · 3 comments · May be fixed by #1870
Open
3 tasks done

Restore support of breadcrumbs.enabled, window.titleBarStyle, and workbench.editor.highlightModifiedTabs advanced settings #1733

kittaakos opened this issue Dec 1, 2022 · 3 comments · May be fixed by #1870
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Dec 1, 2022 •
edited by per1234
Loading

Describe the request

Originally from here:

Partially resolves:

Reply from here:

  • breadcrumbs.enabled has no effect

The breadcrumbs feature has been forcefully removed from IDE2.

  • window.titleBarStyle has no effect

This has also been removed long ago.

  • workbench.editor.highlightModifiedTabs has no effect

I do not know what's this.

I can create a follow-up with these items.

Closing with the following comments from here:

breadcrumbs.enabled has no effect

The breadcrumbs feature has been forcefully removed from IDE2.

window.titleBarStyle has no effect

This has also been removed long ago.

If the settings are not expected to work, I think it is reasonable to explain that in #1077 and consider documenting the fact in the issue report to be sufficient. These settings are intended to be targeted exclusively to advanced users so we don't need to be so concerned about the user experience being polished.

I don't know whether any further action to improve on the current situation is possible.

workbench.editor.highlightModifiedTabs has no effect

I do not know what's this.

You can see the feature in effect in VS Code here (I am using the "Light+ (default light)" theme in the screenshot, but I also see the border in all the other themes I checked: "Dark (Visual Studio)", "Light (Visual Studio)", and "Dark High Contrast"):

image

Describe the current behavior

See the request description 👆

If restoring the lost features is trivial, this should be covered in this task. If it's not trivial or it causes performance issues, etc., then the reason for the missing features should be explained in #1077.

Arduino IDE version

5695fd8

Operating system

macOS, N/A

Operating system version

12.5.1

Additional context

Related to #1077

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest nightly build
  • My request contains all necessary details
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Dec 1, 2022
@kittaakos kittaakos self-assigned this Dec 1, 2022
@kittaakos kittaakos mentioned this issue Dec 1, 2022
Merged
4 tasks
@per1234 per1234 mentioned this issue Dec 1, 2022
Closed
3 tasks
@kittaakos kittaakos mentioned this issue Feb 9, 2023
Open
3 tasks
@kittaakos
Copy link
Contributor Author

  • window.titleBarStyle has no effect

This is currently not supported by Theia on macOS. See here. The preference is connected to another setting value: window.menuBarVisibility. This preference is also disabled in Theia on macOS. Both preferences must be supported, or there is no way to show a custom title bar.

I put together a preview from the latest Theia sources, and somebody has to decide what IDE2 wants to do with the preference once they are available. Please look at how it works on resizing concerning overlay, menu, etc.:

custom-titlebar.mp4
  • On macOS, the window control buttons must be moved to the left, and custom button styles are needed to provide a native look and feel.
  • Figure out if IDE2 wants to support menus on the title bar. If not, the styling issues 👆 still be fixed on Windows and Linux.

@kittaakos kittaakos linked a pull request Feb 9, 2023 that will close this issue
Draft
4 tasks
kittaakos pushed a commit that referenced this issue Feb 9, 2023
fix: restored window.titleBarStyle
7b8538e 
Ref: #1733

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos
Copy link
Contributor Author

  • workbench.editor.highlightModifiedTabs has no effect

Upstream: eclipse-theia/theia#12185

kittaakos pushed a commit that referenced this issue Feb 15, 2023
fix: restored window.titleBarStyle
9ffe421 
Ref: #1733

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Feb 15, 2023
fix: restored breadcrumbs.enabled
88cd571 
Ref: #1733
Signed-off-by: Akos Kitta <[email protected]>
@per1234 per1234 mentioned this issue Jul 2, 2023
Closed
3 tasks
@kittaakos
Copy link
Contributor Author

From #2229 (comment):

Describe the request

the menu bar looks somewhat out of place if your theme's backgound differs from pure grey

Describe the current behavior

the menu bar is not effected by your theme

Arduino IDE version

2.2.1

Operating system

Windows

Operating system version

10

@kittaakos kittaakos mentioned this issue Sep 19, 2023
Closed
3 tasks
@kittaakos kittaakos removed their assignment Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: restore window.titleBarStyle and breadcrumbs.enabled arduino/arduino-ide
1 participant
@kittaakos