Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annular Core Regions in ghastly #16

Open
ZoeRichter opened this issue Oct 1, 2024 · 0 comments
Open

Annular Core Regions in ghastly #16

ZoeRichter opened this issue Oct 1, 2024 · 0 comments
Assignees
@ZoeRichter
Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Priority:4-Low This work is valuable, but not urgent or mission critical. Type:Feature New feature or feature request Type:Question This issue can be closed with a discussion and/or an answer.
Milestone
Prelim

Comments

@ZoeRichter
Copy link
Collaborator

Currently, there are unused core and region objects in ghastly for annular cylinders and annular cones. These geometries are not currently implemented in the rest of ghastly (such as in core filling), and need additional work to get them coupled properly with LAMMPS. Until they have been fully implemented, such objects will throw a NotImplementedError exception.

However, these objects may be useful later, esp. if full functionality is added down the line. This issue will contain any discussion about annular core regions for the future, and can either be closed by their addition to ghastly, or a decision that they will not be needed.
@ZoeRichter ZoeRichter added Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Priority:4-Low This work is valuable, but not urgent or mission critical. Type:Feature New feature or feature request Type:Question This issue can be closed with a discussion and/or an answer. labels Oct 1, 2024
@ZoeRichter ZoeRichter self-assigned this Oct 1, 2024
@katyhuff katyhuff assigned ZoeRichter and unassigned ZoeRichter Dec 3, 2024
@katyhuff katyhuff added this to the Prelim milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZoeRichter ZoeRichter

Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Priority:4-Low This work is valuable, but not urgent or mission critical. Type:Feature New feature or feature request Type:Question This issue can be closed with a discussion and/or an answer.
Projects
None yet
Milestone
Prelim
Development

No branches or pull requests
2 participants
@katyhuff @ZoeRichter