Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Recirculation - sort pebbles into regions, update history #22

Open
ZoeRichter opened this issue Dec 3, 2024 · 0 comments
Open
Assignees
Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Feature New feature or feature request
Milestone

Comments

@ZoeRichter
Copy link
Collaborator

Part of the process of recirculating pebbles is checking for their regions and updating their positional histories.

Describe the feature you'd like.

Part of recirculating the pebbles is that their regions may change. Their current region ID will need to be updated, and their positional history will need to be updated to include that region. There may be two histories - one for the region at each time step, and one that ignores the time spent in each region. For example, if a pebble spent 1, 2, and 3 sim-steps in regions A, B, and C respectively, the long-history would read [A, B, B, C, C, C], while the short list would only read [A, B, C]. Both may be necessary to explore the fidelity of the fuel isotopics modeled - so it's probably better to make sure you have that now, just in case.

Additional context.

This issue is part of the recirculation issues.

How can this issue be closed?

This issue can be closed with a PR that adds this functionality.

@ZoeRichter ZoeRichter added Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Feature New feature or feature request labels Dec 3, 2024
@katyhuff katyhuff added this to the Prelim milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

2 participants