Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check #4c mistakes normal words for elemental symbols #2

Open
osanstrong opened this issue Jul 22, 2024 · 0 comments
Open

Check #4c mistakes normal words for elemental symbols #2

osanstrong opened this issue Jul 22, 2024 · 0 comments
Assignees
Labels
Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving.

Comments

@osanstrong
Copy link
Collaborator

At the time of writing this issue (commit e8d3b63), the code for section 4c ("Elemental symbols should be capitalized, names should not") uses a basic (somewhat insecure) awk script to make one combined regex pattern for all elemental patterns.

This, expectedly, causes it to overzealously apply this capitalization to words that look like symbols, such as 'be' or 'in'.

(This implementation was quickly implemented to fit in a long pipe of sed commands, and therefore can and should be rewritten, since the script has been reorganized to no longer be one giant pipe.)

This issue can be resolved with a PR that replaces the implementation of 4c (and possibly other element-related edits) with a more thorough, multi-line approach, one which can take such false positives into account.

@osanstrong osanstrong added Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. labels Jul 22, 2024
@osanstrong osanstrong self-assigned this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving.
Projects
None yet
Development

No branches or pull requests

1 participant