Check #4c mistakes normal words for elemental symbols #2
Labels
Difficulty:1-Beginner
This issue does not require expert knowledge and may be a good issue for new contributors.
Priority:2-Normal
This work is important and should be completed ASAP.
Status:1-New
No one has claimed this issue yet. It is in need of solving.
At the time of writing this issue (commit e8d3b63), the code for section 4c ("Elemental symbols should be capitalized, names should not") uses a basic (somewhat insecure) awk script to make one combined regex pattern for all elemental patterns.
This, expectedly, causes it to overzealously apply this capitalization to words that look like symbols, such as 'be' or 'in'.
(This implementation was quickly implemented to fit in a long pipe of sed commands, and therefore can and should be rewritten, since the script has been reorganized to no longer be one giant pipe.)
This issue can be resolved with a PR that replaces the implementation of 4c (and possibly other element-related edits) with a more thorough, multi-line approach, one which can take such false positives into account.
The text was updated successfully, but these errors were encountered: