You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
Request: Currently, when using the PR Generator with GitHub, we are provided with the head_sha. Additionally being provided with merge_commit_sha would be extremely useful.
Motivation: The default behavior of a lot of widely-used GHAs, such as actions/checkout and docker/metadata-action, is to use the test merge commit sha rather than the head sha. Providing this value would mean users have a way of working with PR generator without having to override this behavior throughout their stack, and seeing predicatable values being propagated everywhere.
I'm unfamiliar with GitLab and Gitea but I think based on some quick searching that they too create test merge commits, but at least for GH, it seems like it would require a change
Component: Pull Request Generator
Request: Currently, when using the PR Generator with GitHub, we are provided with the
head_sha
. Additionally being provided withmerge_commit_sha
would be extremely useful.Motivation: The default behavior of a lot of widely-used GHAs, such as
actions/checkout
anddocker/metadata-action
, is to use the test merge commit sha rather than the head sha. Providing this value would mean users have a way of working with PR generator without having to override this behavior throughout their stack, and seeing predicatable values being propagated everywhere.I'm unfamiliar with GitLab and Gitea but I think based on some quick searching that they too create test merge commits, but at least for GH, it seems like it would require a change
merge_commit_sha
Other links:
MergeCommitSHA in the GitHub client
Argo docs for template and params
Information about test merge commit SHA and how it changes
The text was updated successfully, but these errors were encountered: