Dex errors when trying to helm update from 5.27.5 to 5.29.1

[de-slalonde]

Does anyone know how to get around this?

Error: template: argo-cd/templates/dex/deployment.yaml:16:11: executing "argo-cd/templates/dex/deployment.yaml"
at <include "argo-cd.strategy" (mergeOverwrite (deepCopy .Values.global.deploymentStrategy)
.Values.dex.deploymentStrategy)>: error calling include: template: argo-cd/templates/_common.tpl:130:8:
executing "argo-cd.strategy" at <eq $preset.type "Recreate">: error calling eq: incompatible types for
comparison

I've even tried uninstalling totally and doing a fresh install and I get the same thing.

Edit: The issue also happens if I try to install 5.28.0, the version immediately after the one that works for me.

[yu-croco]

Hi @de-slalonde , can you please show me your values.yaml?
I don't get the error with Helm Chart v5.29.1, so I wonder what your condition is. 🤔

[de-slalonde]

It still happens even with the dex section taken out of values.yaml. Here's the whole thing. All of the ${variables} are being passed in by Terraform.

configs:
  cm:
    url: "https://${host_name}"
    dex.config: |
      connectors:
        - type: oidc
          config:
            issuer: https://accounts.google.com
            clientID: ${oauth_client_id}
            clientSecret: ${oauth_client_secret}
          id: google
          name: Google
  credentialTemplates:
    ssh-creds:
      url: [email protected]:mycompany
      sshPrivateKey: |
        ${indent(8,ssh_private_key)}
  params:
    server.insecure: true # ingress controller is handling SSL
  rbac:
    policy.csv: |
      g, [email protected], role:readonly
      g, [email protected], role:admin
      g, [email protected], role:admin
    scopes: "[email]"
  repositories:
    git-repo-argo:
      url: ${git_repo_argo}
    artifact-registry-repo:
      url: myurl/charts
      name: artifact-registry-repo
      type: helm
      password: |
        ${indent(8,ar_reader_json)}
      username: _json_key
      enableOCI: "true"
  secret:
    argocdServerAdminPassword: ${admin_password_bcrypt}
    bitbucketUUID: ${bitbucket_uuid}
server:
  ingress:
    enabled: true
    annotations:
      cert-manager.io/cluster-issuer: letsencrypt-prod-http
      kubernetes.io/ingress.class: nginx
    hosts:
      - ${host_name}
    tls:
      - secretName: argo-tls-secret
        hosts:
          - ${host_name}
  podAnnotations:
    ad.datadoghq.com/server.checks: |
      {
        "argocd": {
          "init_config": {},
          "instances": [
            {
              "api_server_endpoint": "http://%%host%%:8083/metrics"
            }
          ]
        }
      }
  resources:
    requests:
      memory: 32Mi
notifications:
  argocdUrl: "https://${host_name}"
  notifiers:
    service.slack: |
      token: $slack-token
  secret:
    items:
      slack-token: ${slack_api_token}
  subscriptions:
    - recipients:
        - slack:${slack_channel}
  templates: # https://argocd-notifications.readthedocs.io/en/stable/catalog/
    template.app-deployed: |
      email:
        subject: New version of an application {{.app.metadata.name}} is up and running.
      message: |
        {{if eq .serviceType "slack"}}:white_check_mark:{{end}} Application {{.app.metadata.name}} is now running new version of deployments manifests.
      slack:
        attachments: |
          [{
            "title": "{{ .app.metadata.name}}",
            "title_link":"{{.context.argocdUrl}}/applications/{{.app.metadata.name}}",
            "color": "#18be52",
            "fields": [
            {
              "title": "Sync Status",
              "value": "{{.app.status.sync.status}}",
              "short": true
            },
            {
              "title": "Repository",
              "value": "{{.app.spec.source.repoURL}}",
              "short": true
            },
            {
              "title": "Revision",
              "value": "{{.app.status.sync.revision}}",
              "short": true
            }
            {{range $index, $c := .app.status.conditions}}
            {{if not $index}},{{end}}
            {{if $index}},{{end}}
            {
              "title": "{{$c.type}}",
              "value": "{{$c.message}}",
              "short": true
            }
            {{end}}
            ]
          }]
    template.app-health-degraded: |
      email:
        subject: Application {{.app.metadata.name}} has degraded.
      message: |
        {{if eq .serviceType "slack"}}:exclamation:{{end}} Application {{.app.metadata.name}} has degraded.
        Application details: {{.context.argocdUrl}}/applications/{{.app.metadata.name}}.
      slack:
        attachments: |-
          [{
            "title": "{{ .app.metadata.name}}",
            "title_link": "{{.context.argocdUrl}}/applications/{{.app.metadata.name}}",
            "color": "#f4c030",
            "fields": [
            {
              "title": "Sync Status",
              "value": "{{.app.status.sync.status}}",
              "short": true
            },
            {
              "title": "Repository",
              "value": "{{.app.spec.source.repoURL}}",
              "short": true
            }
            {{range $index, $c := .app.status.conditions}}
            {{if not $index}},{{end}}
            {{if $index}},{{end}}
            {
              "title": "{{$c.type}}",
              "value": "{{$c.message}}",
              "short": true
            }
            {{end}}
            ]
          }]
    template.app-sync-failed: |
      email:
        subject: Failed to sync application {{.app.metadata.name}}.
      message: |
        {{if eq .serviceType "slack"}}:exclamation:{{end}}  The sync operation of application {{.app.metadata.name}} has failed at {{.app.status.operationState.finishedAt}} with the following error: {{.app.status.operationState.message}}
        Sync operation details are available at: {{.context.argocdUrl}}/applications/{{.app.metadata.name}}?operation=true .
      slack:
        attachments: |-
          [{
            "title": "{{ .app.metadata.name}}",
            "title_link":"{{.context.argocdUrl}}/applications/{{.app.metadata.name}}",
            "color": "#E96D76",
            "fields": [
            {
              "title": "Sync Status",
              "value": "{{.app.status.sync.status}}",
              "short": true
            },
            {
              "title": "Repository",
              "value": "{{.app.spec.source.repoURL}}",
              "short": true
            }
            {{range $index, $c := .app.status.conditions}}
            {{if not $index}},{{end}}
            {{if $index}},{{end}}
            {
              "title": "{{$c.type}}",
              "value": "{{$c.message}}",
              "short": true
            }
            {{end}}
            ]
          }]
    template.app-sync-running: |
      email:
        subject: Start syncing application {{.app.metadata.name}}.
      message: |
        The sync operation of application {{.app.metadata.name}} has started at {{.app.status.operationState.startedAt}}.
        Sync operation details are available at: {{.context.argocdUrl}}/applications/{{.app.metadata.name}}?operation=true .
      slack:
        attachments: |-
          [{
            "title": "{{ .app.metadata.name}}",
            "title_link":"{{.context.argocdUrl}}/applications/{{.app.metadata.name}}",
            "color": "#0DADEA",
            "fields": [
            {
              "title": "Sync Status",
              "value": "{{.app.status.sync.status}}",
              "short": true
            },
            {
              "title": "Repository",
              "value": "{{.app.spec.source.repoURL}}",
              "short": true
            }
            {{range $index, $c := .app.status.conditions}}
            {{if not $index}},{{end}}
            {{if $index}},{{end}}
            {
              "title": "{{$c.type}}",
              "value": "{{$c.message}}",
              "short": true
            }
            {{end}}
            ]
          }]
    template.app-sync-status-unknown: |
      email:
        subject: Application {{.app.metadata.name}} sync status is 'Unknown'
      message: |
        {{if eq .serviceType "slack"}}:exclamation:{{end}} Application {{.app.metadata.name}} sync is 'Unknown'.
        Application details: {{.context.argocdUrl}}/applications/{{.app.metadata.name}}.
        {{if ne .serviceType "slack"}}
        {{range $c := .app.status.conditions}}
            * {{$c.message}}
        {{end}}
        {{end}}
      slack:
        attachments: |-
          [{
            "title": "{{ .app.metadata.name}}",
            "title_link":"{{.context.argocdUrl}}/applications/{{.app.metadata.name}}",
            "color": "#E96D76",
            "fields": [
            {
              "title": "Sync Status",
              "value": "{{.app.status.sync.status}}",
              "short": true
            },
            {
              "title": "Repository",
              "value": "{{.app.spec.source.repoURL}}",
              "short": true
            }
            {{range $index, $c := .app.status.conditions}}
            {{if not $index}},{{end}}
            {{if $index}},{{end}}
            {
              "title": "{{$c.type}}",
              "value": "{{$c.message}}",
              "short": true
            }
            {{end}}
            ]
          }]
    template.app-sync-succeeded: |
      email:
        subject: Application {{.app.metadata.name}} has been successfully synced.
      message: |
        {{if eq .serviceType "slack"}}:white_check_mark:{{end}} Application {{.app.metadata.name}} has been successfully synced at {{.app.status.operationState.finishedAt}}.
        Sync operation details are available at: {{.context.argocdUrl}}/applications/{{.app.metadata.name}}?operation=true .
      slack:
        attachments: |-
          [{
            "title": "{{ .app.metadata.name}}",
            "title_link":"{{.context.argocdUrl}}/applications/{{.app.metadata.name}}",
            "color": "#18be52",
            "fields": [
            {
              "title": "Sync Status",
              "value": "{{.app.status.sync.status}}",
              "short": true
            },
            {
              "title": "Repository",
              "value": "{{.app.spec.source.repoURL}}",
              "short": true
            }
            {{range $index, $c := .app.status.conditions}}
            {{if not $index}},{{end}}
            {{if $index}},{{end}}
            {
              "title": "{{$c.type}}",
              "value": "{{$c.message}}",
              "short": true
            }
            {{end}}
            ]
          }]
  triggers:
    trigger.on-deployed: |
      - description: Application is synced and healthy. Triggered once per commit.
        oncePer: app.status.sync.revision
        send:
        - app-deployed
        when: app.status.operationState.phase in ['Succeeded'] and app.status.health.status == 'Healthy'
    trigger.on-health-degraded: |
      - description: Application has degraded
        send:
        - app-health-degraded
        when: app.status.health.status == 'Degraded'
    trigger.on-sync-failed: |
      - description: Application syncing has failed
        send:
        - app-sync-failed
        when: app.status.operationState.phase in ['Error', 'Failed']
    trigger.on-sync-running: |
      - description: Application is being synced
        send:
        - app-sync-running
        when: app.status.operationState.phase in ['Running']
    trigger.on-sync-status-unknown: |
      - description: Application status is 'Unknown'
        send:
        - app-sync-status-unknown
        when: app.status.sync.status == 'Unknown'
    trigger.on-sync-succeeded: |
      - description: Application syncing has succeeded
        send:
        - app-sync-succeeded
        when: app.status.operationState.phase in ['Succeeded']
    defaultTriggers: |
      - on-deployed
      - on-health-degraded
      - on-sync-failed
      - on-sync-running
      - on-sync-status-unknown
      - on-sync-succeeded
  resources:
    requests:
      memory: 32Mi
applicationSet:
  resources:
    requests:
      memory: 32Mi
controller:
  podAnnotations:
    ad.datadoghq.com/application-controller.checks: |
      {
        "argocd": {
          "init_config": {},
          "instances": [
            {
              "app_controller_endpoint": "http://%%host%%:8082/metrics"
            }
          ]
        }
      }
  resources:
    requests:
      memory: 32Mi
dex:
  resources:
    requests:
      memory: 32Mi
redis:
  resources:
    requests:
      memory: 32Mi
repoServer:
  podAnnotations:
    ad.datadoghq.com/repo-server.checks: |
      {
        "argocd": {
          "init_config": {},
          "instances": [
            {
              "repo_server_endpoint": "http://%%host%%:8084/metrics"
            }
          ]
        }
      }
  resources:
    requests:
      memory: 32Mi

[yu-croco]

@de-slalonde
Thank you for your info.
It's so weird that I didn't get errors on my local environment (kind cluster) with the values.yaml.... 🤔

Do you use Helm Chart directly to install Argo CD? or use other tools like Terraform / Kustomize ?

[de-slalonde]

Terraform is installing it, using the helm_release resource. It's weird that it's fine up to 5.27.5.

[yu-croco]

Oh via Terraform. Which version of hashicorp/helm do you use for now?

It's weird that it's fine up to 5.27.5.

The code is added in v5.28.0, so I wonder there are some logic that helm_release cannot handle (but Helm Chart itself can handle it).... 🤔

[de-slalonde]

Helm provider version... interesting. It's very old. I'll see what I can do about that.

[de-slalonde]

You nailed it. I was on 2.1.1 and upgraded to 2.9.0 and it works fine now. Thanks!!

[yu-croco]

Yeay! 🚀