Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eos_valiadate_state: Document eos_designs variables that can influence validate-state #4690

Open
ClausHolbechArista opened this issue Nov 6, 2024 · 0 comments

Comments

@ClausHolbechArista
Copy link
Contributor

          Hmm I guess it would make sense to track somewhere which tests can be infuenced by the knob in the structured config and where to set them, Not sure whats the best way forward. Right now people cannot guess from this page that it can be disabled. Maybe another wording?

Also @MaheshGSLAB you have updated eos_designs schema but I think it would be worth to update also eos_cli_config_gen as the key shows up in :

../schema/schema_fragments/port_channel_interfaces.schema.yml:        validate_state:
../schema/schema_fragments/port_channel_interfaces.schema.yml:          description: Set to false to disable interface validation by the `eos_validate_state` role.
../schema/schema_fragments/ethernet_interfaces.schema.yml:        validate_state:
../schema/schema_fragments/ethernet_interfaces.schema.yml:          description: Set to false to disable interface validation by the `eos_validate_state` role.

@ClausHolbechArista would it be ok to make some section in this doc to list which variables can impact validate state (with full path) and then in the test documentation state that this (these) key(s) impacts the test?

Originally posted by @gmuloc in #4679 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant