Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stages to supply JSON formatting hints #75

Open
2 tasks
coldino opened this issue Jan 31, 2020 · 0 comments
Open
2 tasks

Allow stages to supply JSON formatting hints #75

coldino opened this issue Jan 31, 2020 · 0 comments

Comments

@coldino
Copy link
Collaborator

coldino commented Jan 31, 2020

Currently there's a hard-coded list of field sets that should be shorted onto a single line present in automate/jsonutils.py. This code should not have that knowledge.

  • Extend jsonutils to accept a list of field sets during encoding
  • Extend the export stage system, allowing stages to optionally provide a list of field sets

Given Python's regex system caches all regex string compilations there's probably no need to be clever with this.

coldino added a commit that referenced this issue Jan 31, 2020
* First-pass currently extracts:
  * Basic info (name, blueprint, tags)
  * Drag weight and mass
  * Fall damage + speed
  * Walking and sprinting speeds

This change also extends json formatting for neater attack info, but see #75 as this needs improving.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant