Improve KafkaErrorException message

arnaud-lb · Sep 18, 2024 · fc98ddd · fc98ddd
1 parent 554305b
commit fc98ddd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/kafka_error_exception.c b/kafka_error_exception.c
@@ -39,7 +39,8 @@ void create_kafka_error(zval *return_value, const rd_kafka_error_t *error) /* {{
 {
     object_init_ex(return_value, ce_kafka_error);
 
-    zend_update_property_string(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("message"), rd_kafka_error_name(error));
+    zend_string *message = zend_strpprintf(0, "%s (RD_KAFKA_RESP_ERR_%s)", rd_kafka_error_string(error), rd_kafka_error_name(error));
+    zend_update_property_str(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("message"), message);
     zend_update_property_long(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("code"), rd_kafka_error_code(error));
     zend_update_property_string(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("error_string"), rd_kafka_error_string(error));
     zend_update_property_bool(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("isFatal"), rd_kafka_error_is_fatal(error));

diff --git a/tests/init_transaction_not_configured.phpt b/tests/init_transaction_not_configured.phpt
@@ -29,7 +29,7 @@ try {
 }
 
 --EXPECTF--
-_NOT_CONFIGURED
+The Transactional API requires transactional.id to be configured (RD_KAFKA_RESP_ERR__NOT_CONFIGURED)
 -145
 %s/tests/init_transaction_not_configured.php
 14