Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of features deprecated for removal #655

Open
starksm64 opened this issue Dec 17, 2024 · 1 comment
Open

Remove usage of features deprecated for removal #655

starksm64 opened this issue Dec 17, 2024 · 1 comment

Comments

@starksm64
Copy link
Member

A scan for usage of classes deprecated for removal in the current codebase shows by the jdeprscan tool shows:

starksm@Scotts-Mac-Studio sms-arq-core % bash depscan.sh
Jar file ./core/impl-base/target/arquillian-core-impl-base-1.9.2.Final-SNAPSHOT.jar:
class org/jboss/arquillian/core/impl/loadable/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
class org/jboss/arquillian/core/impl/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
...
Jar file ./core/spi/target/arquillian-core-spi-1.9.2.Final-SNAPSHOT.jar:
class org/jboss/arquillian/core/spi/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
...
Jar file ./test/impl-base/target/arquillian-test-impl-base-1.9.2.Final-SNAPSHOT.jar:
class org/jboss/arquillian/test/impl/enricher/resource/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
...
Jar file ./junit/core/target/arquillian-junit-core-1.9.2.Final-SNAPSHOT.jar:
class org/jboss/arquillian/junit/State$1 uses deprecated method java/lang/Integer::<init>(I)V (forRemoval=true)
class org/jboss/arquillian/junit/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
...
Jar file ./container/impl-base/target/arquillian-container-impl-base-1.9.2.Final-SNAPSHOT.jar:
class org/jboss/arquillian/container/impl/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
class org/jboss/arquillian/container/impl/client/container/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
class org/jboss/arquillian/container/impl/client/deployment/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
...
class org/jboss/arquillian/container/test/spi/util/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
Jar file ./container/spi/target/arquillian-container-spi-1.9.2.Final-SNAPSHOT.jar:
class org/jboss/arquillian/container/spi/client/deployment/DeploymentScenario$2 uses deprecated method java/lang/Integer::<init>(I)V (forRemoval=true)
class org/jboss/arquillian/container/spi/client/deployment/DeploymentScenario$3 uses deprecated method java/lang/Integer::<init>(I)V (forRemoval=true)
class org/jboss/arquillian/container/spi/client/deployment/DeploymentScenario$1 uses deprecated method java/lang/Integer::<init>(I)V (forRemoval=true)
...
Jar file ./container/test-impl-base/target/arquillian-container-test-impl-base-1.9.2.Final-SNAPSHOT.jar:
class org/jboss/arquillian/container/test/impl/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
class org/jboss/arquillian/container/test/impl/client/deployment/ContainerDeployer uses deprecated class java/security/AccessController (forRemoval=true)
class org/jboss/arquillian/container/test/impl/client/deployment/AbstractDeploymentScenarioGenerator$1 uses deprecated method java/lang/Integer::<init>(I)V (forRemoval=true)
...
Jar file ./testenrichers/cdi/target/arquillian-testenricher-cdi-1.9.2.Final-SNAPSHOT.jar:
class org/jboss/arquillian/testenricher/cdi/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
...
Jar file ./testenrichers/resource/target/arquillian-testenricher-resource-1.9.2.Final-SNAPSHOT.jar:
class org/jboss/arquillian/testenricher/resource/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
Jar file ./testenrichers/ejb/target/arquillian-testenricher-ejb-1.9.2.Final-SNAPSHOT.jar:
class org/jboss/arquillian/testenricher/ejb/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
...
Jar file ./protocols/servlet/target/arquillian-protocol-servlet-1.9.2.Final-SNAPSHOT.jar:
class org/jboss/arquillian/protocol/servlet/runner/SecurityActions uses deprecated class java/security/AccessController (forRemoval=true)
...
Jar file ./protocols/jmx/target/arquillian-protocol-jmx-1.9.2.Final-SNAPSHOT.jar:
class org/jboss/arquillian/protocol/jmx/JMXTestRunner uses deprecated class java/security/AccessController (forRemoval=true)

The depscan.sh script was:

JARS=$(find . -name '*.jar')
JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-23.jdk/Contents/Home

$JAVA_HOME/bin/jdeprscan --for-removal $JARS 2>&1 | grep -v cannot

The summary only shows the jars that had deprecated uses.

@jamezp
Copy link
Collaborator

jamezp commented Dec 17, 2024

It looks like a good chunk of these are security manager related. IMO we shouldn't pull those out yet as I know for WildFly at least we still need security manager support.

I will say it could make sense to move them all into a SecurityActions type of class, like some already are, so when the day comes the API's are actually removed, we could have an Muli-Release JAR where they are no-ops for that version and higher.

We could probably solve the other deprecation's fairly easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants