-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Await strategy: Await ping service #283
Comments
how about trying other commands that runs pretty similar as
|
maybe this is the right time to incorporate propper api for connection checks on application layer, afaik port binding done doesnt necessarilly mean the target app under test is fully running |
i have connection checks on tcp and udp layer based on spacelift reexecution feature of connection tasks, could not that just be called repeatedly until successful connection or timeout? |
This is the polling strategy right?
|
A Health API Ping would be a common strategy. |
we can use https://github.com/vishnubob/wait-for-it but this implies copying that file into container and execute it. This change could be related with #333 |
@aslakknutsen can I close this issue with won't fixed since now we can register custom await strategies? |
@lordofthejars Sure, but maybe create a new one for e.g. 'HTTPAwaitStrategy' that can verify a HTTP response by content/status code ? |
In lights of 'ss' seemingly being removed from all over the place to align the content of base docker images, I think we can expect ss to be more and more un available in the future:
jboss-dockerfiles/base#5
A possible await strategy could be to deploy a minimal container that can ping the target containers from inside the machine/host.
Of course, the question remains, when do we know the Ping container is up and running? I guess we could create a resilliant await client that can attempt a few times before failing. With a minimal sized image it shouldn't take long to start the service.
The text was updated successfully, but these errors were encountered: