Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Await strategy: Await ping service #283

Closed
aslakknutsen opened this issue Feb 4, 2016 · 8 comments
Closed

New Await strategy: Await ping service #283

aslakknutsen opened this issue Feb 4, 2016 · 8 comments

Comments

@aslakknutsen
Copy link
Member

In lights of 'ss' seemingly being removed from all over the place to align the content of base docker images, I think we can expect ss to be more and more un available in the future:
jboss-dockerfiles/base#5

A possible await strategy could be to deploy a minimal container that can ping the target containers from inside the machine/host.

Of course, the question remains, when do we know the Ping container is up and running? I guess we could create a resilliant await client that can attempt a few times before failing. With a minimal sized image it shouldn't take long to start the service.

@lordofthejars
Copy link
Member

how about trying other commands that runs pretty similar as ss? Do you think all of them are going to be removed? Also I am still see two options:

  1. user need to create a dockerfile that installs ss.
  2. we can install it by letting user set the command to execute to install it.

@smiklosovic
Copy link
Member

maybe this is the right time to incorporate propper api for connection checks on application layer, afaik port binding done doesnt necessarilly mean the target app under test is fully running

@smiklosovic
Copy link
Member

i have connection checks on tcp and udp layer based on spacelift reexecution feature of connection tasks, could not that just be called repeatedly until successful connection or timeout?

@lordofthejars
Copy link
Member

This is the polling strategy right?
El 6/2/2016 10:10 a. m., "Štefan Miklošovič" [email protected]
escribió:

i have connection checks on tcp and udp layer based on spacelift
reexecution feature of connection tasks, could not that just be called
repeatedly until successful connection or timeout?


Reply to this email directly or view it on GitHub
#283 (comment)
.

@aslakknutsen
Copy link
Member Author

A Health API Ping would be a common strategy.

@lordofthejars
Copy link
Member

we can use https://github.com/vishnubob/wait-for-it but this implies copying that file into container and execute it. This change could be related with #333

@lordofthejars
Copy link
Member

@aslakknutsen can I close this issue with won't fixed since now we can register custom await strategies?

@aslakknutsen
Copy link
Member Author

@lordofthejars Sure, but maybe create a new one for e.g. 'HTTPAwaitStrategy' that can verify a HTTP response by content/status code ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants