Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress signature stripping #81

Open
Vampire opened this issue Apr 24, 2020 · 1 comment
Open

Suppress signature stripping #81

Vampire opened this issue Apr 24, 2020 · 1 comment

Comments

@Vampire
Copy link

Vampire commented Apr 24, 2020

We have a functionality where the signature of an uploaded JAR is validated.
To test this we have a signed JAR as part of the deployment to then get it via Class#getResourceAsStream.
Now that we added this extension, the tests fail, because the signature is stripped even though the JAR does not even contain class files.
I work-arounded the problem by renaming the jars to .jar_for_test which prevents the signature killer to catch it and so got the tests green again.
But I spent a day to find out, why there is no signature while the artifact that should be deployed had the signature in place properly.
It would be nice to have a configuration option with which the signature killing could be suppressed for certain files.

@bartoszmajsak
Copy link
Member

Hi @Vampire, thanks for reporting that problem. It's a use case we haven't thought of.

Since you have all bits in place to test such an improvement could you help us bring this for the community through a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants