Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to Stdlib values are broken #43

Open
muzimuzhi opened this issue Sep 4, 2024 · 1 comment
Open

Links to Stdlib values are broken #43

muzimuzhi opened this issue Sep 4, 2024 · 1 comment

Comments

@muzimuzhi
Copy link

muzimuzhi commented Sep 4, 2024

For example, fst has

val Stdlib.fst : ('a * 'b) -> 'a

on the top of search result list, but the link added to Stdlib.fst is missing the Stdlib right before .html.

It seems all links to values documented in https://ocaml.org/manual/5.1/api/Stdlib.html have the same problem.

However links to values documented in standard library modules are alright, for example List.map shows Stdlib.List.map correctly linked to https://v2.ocaml.org/releases/5.1/api/List.html#VALmap.

@art-w
Copy link
Owner

art-w commented Sep 5, 2024

Oh that's the shame, thanks for the report! (I like your profile description :D )

In case someone has time to look into this before I do this weekend, we have a bunch of hacks to link to the stdlib as it has different urls than odoc: https://github.com/art-w/sherlodoc/blob/master/db/entry.ml#L90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants