-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Naming Conventions (7.2.3) #85
Comments
We are aware of this issue but recommend waiting until no other PRs are open: Then we could simply create a branch for the file name changes and merge it without any conflicts. Does that work for you or do you feel this is urgent? |
Also, as this relates to #68 I'd propose closing that issue and keeping the discussion/progress in this issue, ok? |
This is not in any case related to #68. This issue here is about the naming convention for OpenMATERIAL assets that should go into the documentation. |
Is your feature request related to a problem? Please describe.
Describe the solution you'd like Describe alternatives you've consideredAdditional context |
We have added "starting with capital letters" to the metadata naming convention. For consistency, then all fields in the json fields should be capital letters. Also the material properties in the corresponding files. Officially there are some hard restrictions, that do not touch this: https://jsonapi.org/format/#document-member-names |
Since this is relevant to all further development in both sub-groups, we should make a decision fast. What is your opinion @LudwigFriedmann ? |
Hi @ClemensLinnhoff, If there's a binding restriction from JSON here I'd rather change our naming scheme for file and node names, We should discuss this in the group. |
@ClemensLinnhoff @LudwigFriedmann I will wait with this topic until the next group meeting then. But I can say upfront, that I am personally not a big fan of camelCase (with a lower first letter) for the node structure, because it is harder to read for the human eye in the 3D application. It could be benefitial to use different naming conventions here. |
I agree with @ipg-sig. I also don't like camelCase at all. But I am also a bit reluctant to go against a common convention. |
We did a quick poll in the material group meeting: snake_case: 2 |
Comment from @ipg-sig in the material meeting: |
We did a quick poll in the gometry group meeting: snake_case: 1 -> Decision: use camelCase for JSON parameters |
WIP Naming conventions The following naming conventions apply to ASAM OpenMATERIAL geometry files: File Names
Node Structure for the 3D Model
**Subkeys ** Vehicles: General naming structure: <Component_Idx>_Specification_Idx_Idx
Additional recommended Subkeys
An example vehicle structure can be found in chapter (add link to chapter from #103 ). Human: Predefined Subkeys
General naming structure: BoneName_SideIndicator Predefined Bone Names
Recommended Names for additional bone names
An example human structure can be found in chapter (add link to chapter from #103 ). Environment: General naming structure: ObjectName_Idx
Metadata
Needs to be discussed in the group:
|
In my opinion we could still use snake_case for the node in the 3D geometry. As I see it, we just agreed on the lowerCamelCase for the fields in the json files, as this is the recommended style for json. |
That would be great. I understood it so, that you wanted to have the lowerCamelCase consistently in every file. Would be great, if we only use it in the json files, metadata. Thats why I stopped yesterday and wanted to clarify it in the group. |
Blender
Blender requires this naming for mirroring at first place, but after mirroring, nodes can be renamed again. This creates overhead but doesn't prevent mirroring. |
Group Decision: Keep snake case (as it is) due to better readability for 3D model structure. |
Open questions:
Othwerwise i would make the following proposal: Add States to Meta data for hidden objects and states.
Please feel free to comment: @LudwigFriedmann @ClemensLinnhoff @MatthiasThDs @KimuraDIVP @lyndyRott @MustafaTrian @DavidJRitter904 |
|
Is your feature request related to a problem? Please describe.
[WIP] In the documentation of the Geometry Subgroup on Naming conventions, some information is missing:
** Naming of nodes shall be accoding to SnakeCase definition, starting with capital letters
** (tbd)
** Naming of nodes shall be accoding to SnakeCase definition, starting with capital letters
** Empty Nodes should have "Grp_"Prefix
** Iterators are added as suffixes. In the documentation, iteraror names in pointy braces are used to illustrate their positioning.
** ENUMs (e.g. from OpenDRIVE road/lane type) should be added as suffixes in capital letters
** Sequence of suffixes (tbd)
** (tbd)
WIP - Current State- Naming conventions
The following naming conventions apply to ASAM OpenMATERIAL geometry files:
File Names
Example: omg_Example.gltf, omg_Example.xoma
Node Structure for the 3D Model
Subkeys
To allow a consistent naming convention and parsing, some subkeys and keywords are already predefined by the standard. more could follow in future updates. The User is free to add more subkeys for himself, if they are needed.
Vehicles:
General naming structure: <Component_Idx>_Specification_Idx_Idx
Additional recommended Subkeys/ vehicle part names
An example vehicle structure can be found in chapter (add link to chapter from #103 ).
Human:
Predefined Subkeys
General naming structure: BoneName_SideIndicator
Predefined Bone Names
Recommended Names for additional bone names
An example human structure can be found in chapter (add link to chapter from #103 ).
Environment:
General naming structure: ObjectName_Idx
Metadata
Needs to be discussed in the group:
-(State) of Appearance: Open or Closed. Can be used to define the standard appearance.
The text was updated successfully, but these errors were encountered: