Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove runtime from configui #64

Merged
merged 9 commits into from
May 30, 2024

Conversation

romanodanilo
Copy link
Contributor

@romanodanilo romanodanilo commented May 30, 2024

Description

Remove from ConfigGUI all the elements related to runtime and command execution

The new ConfigGUI allows to edit and save a configuration file in a simplified version. UI is shown below:

Screenshot from 2024-05-30 10-40-15

Main changes

  1. Remove run/pause button
  2. Remove c_process_log c_runtime_control and c_runtime_thread class files
  3. Remove autostart parameter and logic since no execution start is needed anymore
  4. Add XML validation when saving XML file. Before the validation was performed only when the runtime was executed. In order to help the users writing formally valid XML, now the xml validation is performed everytime a configuration is saved. In case of error the saving is avoided and the following QDialog appears

Screenshot from 2024-05-30 11-13-53

How was the PR tested?

  1. Launched UI locally, edited and saved configuration files

Notes

Signed-off-by: romanodanilo <[email protected]>
@romanodanilo romanodanilo marked this pull request as ready for review May 30, 2024 09:15
Copy link
Collaborator

@hoangtungdinh hoangtungdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romanodanilo

@hoangtungdinh hoangtungdinh self-requested a review May 30, 2024 09:53
@hoangtungdinh hoangtungdinh merged commit 6922c51 into develop May 30, 2024
3 checks passed
@hoangtungdinh hoangtungdinh deleted the danilo/remove_runtime_from_configui branch May 30, 2024 12:21
hoangtungdinh pushed a commit that referenced this pull request Jun 4, 2024
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
hoangtungdinh pushed a commit that referenced this pull request Jun 5, 2024
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
hoangtungdinh pushed a commit that referenced this pull request Jun 5, 2024
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
hoangtungdinh pushed a commit that referenced this pull request Jun 5, 2024
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
pmai pushed a commit that referenced this pull request Jun 6, 2024
Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants