Revert "Only report edge plugin health if sync is enabled." #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7a6f2ee.
Pull Request Test Coverage Report for Build 11220289365Details
💛 - Coveralls |
gertd
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7a6f2ee.
It was a mistake to omit the "sync" health status when the edge plugin isn't enabled. The plugin can be enabled and disabled dynamically through discovery calls and it's better to always include its status in the health service.
I originally made the change because it looked like the kubernetes startup probe was getting back NOT_SERVING responses, but I tested it again with the change in this PR and the overall pod health is reported as healthy even if the "sync" service's status is NOT_SERVING.