Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Proposal] SQL hook has no attribute 'set_up' #63

Open
Patataman opened this issue Apr 29, 2022 · 0 comments
Open

[BUG] [Proposal] SQL hook has no attribute 'set_up' #63

Patataman opened this issue Apr 29, 2022 · 0 comments

Comments

@Patataman
Copy link
Contributor

SQL Hooks (and MongoHooks as far as I have seen) are splitted into 2 different methods:

def sumUrl_set_up(*args, **kwargs):
        tables = ["url_hourly", "url_daily", "url_monthly"]
        create_tables(tables, **kwargs)

def sumUrl(**kwargs):
    if not _check_environment(**kwargs):
        return
    if not _check_postgresql(**kwargs):
        raise NotImplementedError("Only PostgreSQL currently supported")
        return
    [...]

However in the Storage class method __init__ it is called as the following:

Two solutions came to my mind:

  1. Change Storage.__init__ to call <hook>_set_up function instead.
  2. Change how hooks are created to be classes instead methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant