Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio images not working #111

Closed
Seifo-Ibrahim opened this issue Feb 15, 2021 · 12 comments
Closed

Portfolio images not working #111

Seifo-Ibrahim opened this issue Feb 15, 2021 · 12 comments

Comments

@Seifo-Ibrahim
Copy link

Seifo-Ibrahim commented Feb 15, 2021

لقطة الشاشة 2021-02-15 183716
After clone repository Portfolio images not working

@dhruvkrishnavaid
Copy link
Contributor

It works perfectly fine for me. Please list all the steps you have done...

@NirmalSilwal
Copy link

NirmalSilwal commented Oct 6, 2021

I have similar issue as @Seifo-Ibrahim. Can someone help me resolve it? I have added images in /src/assets/images/ folder. Is there any other location I need to add the images to render in the Education and Certificate section?

Tagging @dhruvkrishnavaid @ashutosh1919 @danielmarostica @th3c0d3br34ker @a-mishra
Please take a look at this issue.

Attaching screenshot of my issue -

Capture

snapshot of code in portfolio.js

Capture1

You can check the images are in correct folder also.

logoscollection

@NirmalSilwal
Copy link

Also the profile image is not displayed in Contact page. Can someone suggest the potential solution?

@dhruvkrishnavaid
Copy link
Contributor

dhruvkrishnavaid commented Oct 7, 2021

Ok, so I've finally found out the fix.


The probable issue:
The modules have been updated to their latest versions...


The fix:
In ./src/components/degreeCard/degreeCard.js:19,
change src={require(`../../assests/images/${degree.logo_path}`)} to src={require(`../../assests/images/${degree.logo_path}`).default}.

In ./src/components/certificationCard/certificationCard.js:25,
change src={require(`../../assests/images/${certificate.logo_path}`)} to src={require(`../../assests/images/${certificate.logo_path}`).default}.

In ./pages/contact/ContactComponent.js:29,
change src={require(`../../assests/images/${ContactData["profile_image_path"]}`)} to src={require(`../../assests/images/${ContactData["profile_image_path"]}`).default}.

Similarly, change all the srcs' of the img tags.

@NirmalSilwal
Copy link

Awesome, just now I have reached that file folder debugging the code. Very funny that I don't know Javascript but still trying to debug react code. :)

Capture

Thank you, I will update with the issue soon. 👍

@dhruvkrishnavaid
Copy link
Contributor

@NirmalSilwal Please comment if the issue is fixed.

@NirmalSilwal
Copy link

NirmalSilwal commented Oct 7, 2021

@dhruvkrishnavaid it is now fixed for Education, certificates and contact section. Now the logo are not displayed in the Experience section. Trying to fix that and will update you.

I have also issue with Open Source section. It is not working. I have mentioned in another issue about that.

@NirmalSilwal
Copy link

Hi @dhruvkrishnavaid just for the update, all of the images and logos are fixed now. Now that open source section is the problem as running node git_data_fetcher.js is giving the exceptions.

@NirmalSilwal
Copy link

update - open source section is also now fetched but I see in the organization list at the top, it is displaying only 3 org but I have contributed to other org also in the past. Why is all org not displayed? Is there any time frame filter applied?

@dhruvkrishnavaid
Copy link
Contributor

update - open source section is also now fetched but I see in the organization list at the top, it is displaying only 3 org but I have contributed to other org also in the past. Why is all org not displayed? Is there any time frame filter applied?

@NirmalSilwal Please open a new issue for that as it's totally a different issue.

@NirmalSilwal
Copy link

done

check #159

@saiteja13427
Copy link
Collaborator

I think this issue is now resolved, thus closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants