Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-test list --changed-since #276

Open
sateeshperi opened this issue Nov 29, 2024 · 5 comments
Open

nf-test list --changed-since #276

sateeshperi opened this issue Nov 29, 2024 · 5 comments

Comments

@sateeshperi
Copy link
Contributor

sateeshperi commented Nov 29, 2024

would it be possible to extend the --changed-since param to nf-test list as well ? @lukfor

currently, it is used only in the nf-test test --ci context but, getting to know the changed files assumes all the detected tests will be run on the same runner or by sharding expand to multiple runners. But, since we would have no control over which job will be picked up by a runner we need to be able to see the changed files before the test command for filtering tests based on tags for example., we are trying to separate the jobs based on the tag gpu and the appropriate runner to run it on.

Having a list changed-since feature nf-test list --changed-since HEAD^ will be a nice feature to have for easy debugging and simplified and flexible CI

@sateeshperi
Copy link
Contributor Author

sateeshperi commented Dec 1, 2024

adding on a suggestion from @GallVp

The nf-test test --ci test feature could be made more flexible with the following params:

  • --excludeTags
  • --excludePaths/--excludeTests

@sateeshperi
Copy link
Contributor Author

linking a similar feature request issue #180

@maxulysse
Copy link

maxulysse commented Dec 3, 2024

Hi @lukfor , I'm noticing @sateeshperi work on nf-core/modules#7025.
Currently we're implementing our own idea to solve what would be much easier with --exclude* options.
(ie adding tags to all tests so that we can select just them).
🙏
Any idea if you plan to include that in any future release?
🙏

@lukfor
Copy link
Collaborator

lukfor commented Dec 3, 2024

Yes, I will definitely include it. At the moment, I am very busy with teaching but will try to find some time. At the very least, during the Christmas holidays. :)

@maxulysse
Copy link

One of the best news of the day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants