Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you replace iconv with iconv-light? #77

Open
zeg-io opened this issue Dec 19, 2018 · 5 comments
Open

Could you replace iconv with iconv-light? #77

zeg-io opened this issue Dec 19, 2018 · 5 comments

Comments

@zeg-io
Copy link

zeg-io commented Dec 19, 2018

My understanding is light is a completely native solution. I'm currently getting build errors on iconv

@bushev
Copy link

bushev commented Jan 4, 2019

I have the same issue:

../../nan/nan_maybe_43_inl.h:112:15: error: no member named 'ForceSet' in 'v8::Object'

@zeg-io
Copy link
Author

zeg-io commented Jan 4, 2019

I make no guarantees and I'm not maintaining it, but this one I forked and fixed is working for me: https://github.com/zeg-io/xml-stream

@sandinmyjoints
Copy link

The build errors come from a dep of xml-stream, nan. Older versions of it won't build on Node 10. If you install a newish version of nan (2.11 or above, I believe), then it will build (and xml-stream will install).

@zeg-io
Copy link
Author

zeg-io commented Mar 9, 2019

Good to know, but iconv-light doesn't require a build at all and functions just fine, which is why I'd prefer it.

@sandinmyjoints
Copy link

No disagreement here, just offering a way forward for folks stuck with xml-stream as it is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants