Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make modals accessible for screen readers #210

Open
klues opened this issue Dec 15, 2022 · 1 comment · May be fixed by #348
Open

Make modals accessible for screen readers #210

klues opened this issue Dec 15, 2022 · 1 comment · May be fixed by #348
Labels
Accessibility Everything related to Accessibility / WCAG good first issue Good for newcomers

Comments

@klues
Copy link
Contributor

klues commented Dec 15, 2022

Accessibility of modals for screen readers currently is very limited. The modal for "set navigation" in edit mode has better accessibility, which also should be added to other modals, at least:

This change shouldn't be done on each modal manually, but a new Vue component like baseModal.vue should be created which takes care of all basic things for modals and is used by all other modals.
@klues klues added the Accessibility Everything related to Accessibility / WCAG label Dec 15, 2022
@klues klues added the good first issue Good for newcomers label Mar 29, 2023
@klues
Copy link
Contributor Author

klues commented May 23, 2023

Since there is now the new HTML5 element dialog, this should be used instead of the aria and role properties, see: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog

@sabicalija sabicalija linked a pull request Dec 6, 2023 that will close this issue
Open
klues added a commit that referenced this issue Dec 4, 2024
@klues
#210 directly translate in template and don't use computed methods fo…
9010d23 
…r it
klues added a commit that referenced this issue Dec 4, 2024
@klues
#210 added translation for dialog
e1ee24c
klues added a commit that referenced this issue Dec 4, 2024
@klues
#210 removed superfluous method handleClose()
ee6eef2
klues added a commit that referenced this issue Dec 5, 2024
@klues
#210 refactored modalMixin, made it easier to read and understand, ad…
fd4a698 
…ded listener on "close" from baseModal which resets the data of the modal
klues added a commit that referenced this issue Dec 5, 2024
@klues
#210 moved init logic back to mounted(), listen for open event of bas…
d832362 
…eModal to execute the init code
klues added a commit that referenced this issue Dec 5, 2024
@klues
#210 added missing handler for @ok
6688c92
klues added a commit that referenced this issue Dec 5, 2024
@klues
#210 removed emitting of "close", isn't needed anymore, closeModal at…
e016a4b 
… the end, because it resets all data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility Everything related to Accessibility / WCAG good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(a11y): Make modals accessible sabicalija/AsTeRICS-Grid
1 participant
@klues