Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Python 3.13 non free threaded using mimalloc #389

Closed
arnabanimesh opened this issue Nov 6, 2024 · 6 comments · Fixed by #391
Closed

Build Python 3.13 non free threaded using mimalloc #389

arnabanimesh opened this issue Nov 6, 2024 · 6 comments · Fixed by #391

Comments

@arnabanimesh
Copy link

Build Python 3.13 non free threaded using mimalloc instead of obmalloc/pymalloc

@zanieb
Copy link
Member

zanieb commented Nov 10, 2024

Can you explain why you would prefer this?

@arnabanimesh
Copy link
Author

Main reason: The builds in python.org include mimalloc as mentioned in their release notes.

Also, as a minor sidenote, there is a noticeable (although not that much) speed improvement as mentioned in this thread: python/cpython#90815

@zanieb
Copy link
Member

zanieb commented Nov 11, 2024

Okay, thanks!

@zanieb
Copy link
Member

zanieb commented Nov 13, 2024

Please see #391 (comment)

@zanieb zanieb closed this as completed Nov 13, 2024
@arnabanimesh
Copy link
Author

Oh. Nice.

Although as mentioned in your comment #391 (comment), it is better to mention it explicitly in my opinion. Mentioning the --with-mimalloc flag for non free threaded build is like a test case for ensuring that mimalloc support is indeed present when building using CI. Since we are building free threaded builds (which requires mimalloc) for all the target platforms anyways, we need to ensure that mimalloc is being used for non free threaded builds in those target platforms.

@zanieb
Copy link
Member

zanieb commented Nov 14, 2024

Yeah I'll probably continue my work there regardless.

zanieb added a commit that referenced this issue Dec 17, 2024
Previously, it was only explicitly required for the freethreaded builds

Closes #389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants