adds profile_config for Docker #1347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
dosubot
bot
added
area:execution
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1347 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 67 67
Lines 4025 4027 +2
=======================================
+ Hits 3865 3867 +2
Misses 160 160 ☔ View full report in Codecov by Sentry. |
pankajastro
reviewed
Nov 30, 2024
pankajastro
approved these changes
Nov 30, 2024
tatiana
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Hi @andrewhlui, thanks a lot for your contribution!
Some requests:
- Please add a test for this feature
- If possible, update the docs, mentioning any limitations of this feature (comment inline)
If you can address this before 20 December, we can release this feature as part of Cosmos 1.8
| @@ -42,8 +43,10 @@ class DbtDockerBaseOperator(AbstractDbtBaseOperator, DockerOperator): # type: i | |||
| def __init__( | |||
| self, | |||
| image: str, # Make image a required argument since it's required by DockerOperator | |||
| profile_config: ProfileConfig | None = None, | |||
There was a problem hiding this comment.
Does this profile work with ProfileMapping or only with a given profiles.yml file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ProfileConfig to Docker operators so that people can use TaskGroups.
Related Issue(s)
Closes #1346
Breaking Change?
Checklist