Can't filter dbt nodes by tags when using LoadMode.CUSTOM

[yoshimaru46]

issue

when using LoadMode.CUSTOM, tags passed to DbtNode is prefixed with tags:.

astronomer-cosmos/cosmos/dbt/graph.py

Lines 656 to 666 in cfb6bf2

	tags = [selector for selector in model.config.config_selectors if selector.startswith("tags:")]
	node = DbtNode(
	unique_id=f"{model.type.value}.{self.project.project_name}.{model_name}",
	resource_type=DbtResourceType(model.type.value),
	depends_on=list(model.config.upstream_models),
	file_path=Path(
	model.path.as_posix().replace(
	self.render_config.project_path.as_posix(), self.execution_config.project_path.as_posix()
	)
	),
	tags=tags or [],

therefore, _is_tags_subset become always false.

astronomer-cosmos/cosmos/dbt/selector.py

Line 388 in cfb6bf2

if not (set(self.config.tags) <= set(node.tags)):

How to reproduce

model.sql

config(tags=["foo"])

render_config

select=["tag:foo"],

_is_tags_subset

• self.config.tags: set(["foo"])
• node.tags: set(["tags:foo"])

(set(self.config.tags) <= set(node.tags)) => always false

[dosubot]

Hey @yoshimaru46! 👋 I'm here to help you with any bugs, questions, or contributions you have. Let's squash those bugs together!

To resolve the issue where the _is_tags_subset function always returns false due to tags being prefixed with tags: when using LoadMode.CUSTOM, you need to modify the _is_tags_subset function to strip the tags: prefix from the node's tags before performing the subset check. Here's how you can adjust the function:

def _is_tags_subset(self, node: DbtNode) -> bool:
    """Checks if the node's tags are a subset of the config's tags."""
    # Remove 'tags:' prefix from node tags if present
    node_tags = [tag[len('tags:'):] if tag.startswith('tags:') else tag for tag in node.tags]
    if not (set(self.config.tags) <= set(node_tags)):
        return False
    return True

This modification ensures that the tags are compared correctly, allowing the subset check to function as intended ^[1].

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other}

[pankajastro]

Hey @yoshimaru46, would you like to submit a fix?

[yoshimaru46]

PR: #1387 (WIP)