-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: release assets for macos x64 and arm64 (M1) #519
ci: release assets for macos x64 and arm64 (M1) #519
Conversation
Signed-off-by: CyberHippo <[email protected]>
Signed-off-by: CyberHippo <[email protected]>
Signed-off-by: CyberHippo <[email protected]>
Signed-off-by: CyberHippo <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
can you open a separate issue for that topic. I think we in general need to come up with an idea on how to make sure we know earlier that these distros are failing on a release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANKS!!!
/rtm |
🎉 This PR is included in version 0.38.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
The release workflow did not find any macos assets to upload:
This was caused by oclif which is now supporting arm64 arch (See oclif/oclif#847). The macos assets are now
${name}-v${version}-${sha}-x64.pkg
and${name}-v${version}-${sha}-arm64.pkg
:Run ls -la dist/macos/ total 581912 drwxr-xr-x 4 runner staff 128 Apr 13 11:33 . drwxr-xr-x 4 runner staff 128 Apr 13 11:33 .. -rw-r--r-- 1 runner staff 148119971 Apr 13 11:33 asyncapi-v0.37.2-82ba8ff-arm64.pkg -rw-r--r-- 1 runner staff 149812837 Apr 13 11:33 asyncapi-v0.37.2-82ba8ff-x64.pkg
@derberg We could use the glob pattern matching for the
files
of the Actionsoftprops/action-gh-release@v1
instead of passing the full file name. What do you think ?Related issue(s)
See also #501.