Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteStreamAsync Not Exposed to Package Consumers #57

Open
Anders-Toegersen opened this issue Dec 19, 2024 · 1 comment · May be fixed by #58
Open

DeleteStreamAsync Not Exposed to Package Consumers #57

Anders-Toegersen opened this issue Dec 19, 2024 · 1 comment · May be fixed by #58
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@Anders-Toegersen
Copy link

Describe the issue
Currently the DeleteStreamAsync() functionality is not exposed to the package consumer. It is unclear whether this exclusion is intentional or an oversight.

Suggestion 1
Move DeleteStreamAsync() with implementation from IEventStoreManagementClient to IEventStoreClient.

Suggestion 2
Make IEventStoreManagementClient public and move the internal access modifier to the unimplemented methods.

I'm happy to help with code changes. I just need to know which approach is preferred :)

@Anders-Toegersen Anders-Toegersen added bug Something isn't working enhancement New feature or request labels Dec 19, 2024
@LarsSkovslund
Copy link
Collaborator

I think suggestion 1 is the optimal way, and we should remove the IEventStoreManagementClient from the package entirely.

@Anders-Toegersen, I would be grateful if you would implement the changes.

@TomMalow this would also help you with the event-store data migration.

Cheers and happy holidays

@Anders-Toegersen Anders-Toegersen linked a pull request Dec 21, 2024 that will close this issue
@Anders-Toegersen Anders-Toegersen linked a pull request Dec 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants