Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

Create config python file with hardcoded strings #172

Closed
LauJohansson opened this issue Oct 5, 2022 · 2 comments · May be fixed by #227
Closed

Create config python file with hardcoded strings #172

LauJohansson opened this issue Oct 5, 2022 · 2 comments · May be fixed by #227
Labels
enhancement New feature or request

Comments

@LauJohansson
Copy link
Contributor

For avoiding too many manual errors we could introduce a config variable file. E.g. instead of using TableConfigurator().get_property("name") then it is TableConfigurator().get_property(conf.NAME).

conf.py:

NAME = "name"
PARTITIONING="partitioning"
....
@LauJohansson LauJohansson added the enhancement New feature or request label Oct 6, 2022
@LauJohansson
Copy link
Contributor Author

constants.py file.

place under atc/

@LauJohansson LauJohansson linked a pull request Dec 19, 2022 that will close this issue
feat: use centralized constants #227
Open
@mrmasterplan
Copy link
Contributor

This is solved in #210 where you can generate just such a conf.py file from the configurator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use centralized constants atc-net/atc-dataplatform
2 participants
@mrmasterplan @LauJohansson