Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull errwrap linter from "optional" linters set #217

Open
atc0005 opened this issue Nov 19, 2024 · 0 comments
Open

Pull errwrap linter from "optional" linters set #217

atc0005 opened this issue Nov 19, 2024 · 0 comments
Assignees
@atc0005
Labels
bug Something isn't working CI linting

Comments

@atc0005
Copy link
Owner

atc0005 commented Nov 19, 2024

I'm continuing to see false positives from Go code which:

  • places the %w error wrapping verb somewhere other than the last position in the format string
  • places a second %w error wrapping verb in the format string

From what I understand the second is valid since Go 1.20 and the first has been valid since Go 1.13 (though I didn't find a lot of details on that when I looked).

I've filed a bug report with the linter author, but haven't received a response. I've reached out once more.

It's probably worth removing the linter from CI use until I hear back.

See also:
@atc0005 atc0005 added bug Something isn't working CI linting labels Nov 19, 2024
@atc0005 atc0005 self-assigned this Nov 19, 2024
atc0005 added a commit that referenced this issue Nov 19, 2024
@atc0005
Disable "optional" errwrap linter
b4eb429 
Disable until I receive feedback from linter author as the
current release is giving unreliable results.

refs GH-217
@atc0005 atc0005 mentioned this issue Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working CI linting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atc0005