You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Hi i was not able to create a pull request: because apm install fails: node-oniguruma . So i had a look into the code, i think its in tag-finder.coffee in line 134 function tagsNotClosedInFragment. I think a xml specification fulfilling regex would solve this one:
In the mean time this was addressed by #229, however the regex used in this PR (/<(\w[-\w]*(?:\:\w[-\w]*)?)|<\/(\w[-\w]*(?:\:\w[-\w]*)?)/) is simpler and may leave out some cases.
Also:
- Fix a bug in an existing spec concerning the matching of self
closing tags (wrong cursor position)
- Add specs for self-closing tags after the cursor
The problem that is addressed here is that `<foo bar=">"/>` was
previously catched as a normal opening tag. Therfore `(?![^>]*\/>)`
was replaced with `(?:\"[^\"]*\"|'[^']*'|[^>\\/\"'])*>` and to remove
redundency and coplexity the function generateTagStartOrEndRegex was
introduced to generate the affected regexes.
Because we (@ruv and I discussed the regex in the PR) decided to stop
using a negative lookahead in favor of performance and simplicity,
this changed the behavior of the function tagsNotClosedInFragment when
it encounters malformed XML and broke an existing spec that verified
this. However because this behavior was already criticized as not
desirable, I decided to remove the spec.
Any start-tag that contains a prefix is closed incorrectly.
For example,
Ctrl+Alt+.
command after<p:name>
produces</p>
.bracket-matcher version 0.79.0
The text was updated successfully, but these errors were encountered: