You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
What do you think about supporting async and await (aka. a Promise-based API)? I think it would be greate since packages relying on fs-plus (e.g. atom/season) could easily use the cool ES7 async/await as well.
There is another fs extension node-fs-extra that returns Promises if no callback is provided (which I really like). Of course,node-fs-extra carries along some extra methods but those should be able to be ignored easily from what's exported by fs-plus (in case you even care).
Anyway node-fs-extra can be used as a drop in replacement for fs. So it'd be really easy for you to also support the Promise API by using node-fs-extra as a dependency in your package.json instead of the native fs module.
In case you're interested I'd be willing to create a PR.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What do you think about supporting
async
andawait
(aka. aPromise
-based API)? I think it would be greate since packages relying onfs-plus
(e.g. atom/season) could easily use the cool ES7async/await
as well.There is another
fs
extension node-fs-extra that returnsPromise
s if no callback is provided (which I really like). Of course,node-fs-extra
carries along some extra methods but those should be able to be ignored easily from what's exported byfs-plus
(in case you even care).Anyway
node-fs-extra
can be used as a drop in replacement forfs
. So it'd be really easy for you to also support thePromise
API by usingnode-fs-extra
as a dependency in yourpackage.json
instead of the nativefs
module.In case you're interested I'd be willing to create a PR.
The text was updated successfully, but these errors were encountered: