Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Unnecessary getSubmodulePaths #51

Closed
cblp opened this issue Aug 12, 2015 · 1 comment
Closed

Unnecessary getSubmodulePaths #51

cblp opened this issue Aug 12, 2015 · 1 comment

Comments

@cblp
Copy link

cblp commented Aug 12, 2015

I'm trying to solve one particular problem — to get a branch name for a repository inside a given path.

I'm doing

var GitUtils = require('git-utils')
console.log(GitUtils.open(path).getShortHead())

But open performs too slow on sshfs. It takes about 5 or 6 seconds to getSubmodulePaths. The other code takes about 10 ms.

I suggest to delay openSubmodules for the time when it will be needed, and to not call it in open.

@cblp
Copy link
Author

cblp commented Aug 12, 2015

Converted to PR #52

@cblp cblp closed this as completed Aug 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant