Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

New versions of Atom prompt about accessing the keychain to support this package on window startup #171

Open
nathansobo opened this issue Nov 2, 2017 · 7 comments

Comments

@nathansobo
Copy link
Contributor

I just launched Atom 1.21.2 for the first time and saw this:

screen shot 2017-11-02 at 2 48 37 pm

It looks like we're fetching credentials on package activation, when perhaps we should wait until the user tries to share a portal?

@nathansobo nathansobo changed the title New versions of Atom prompt about accessing the keychain to support Tachyon on startup New versions of Atom prompt about accessing the keychain to support this package on window startup Nov 2, 2017
@jsejcksn
Copy link

jsejcksn commented Nov 18, 2017

Similar, but the requesting process is security (presumably /usr/bin/security)

keychain-security-atom-teletype

@winstliu
Copy link
Contributor

It looks like we're fetching credentials on package activation, when perhaps we should wait until the user tries to share a portal?

I addressed this in #234.

@jsejcksn
Copy link

@50Wliu I have always selected Deny at this prompt, and teletype works just fine. Is this dialog necessary? Does #234 remove this dialog?

@jsejcksn
Copy link

Can someone please respond to my questions from 2017 Nov? ^ Is this dialog necessary? Denying it does not seem to affect the operation of Teletype.

@jasonrudolph
Copy link
Contributor

Can someone please respond to my questions from 2017 Nov? Is this dialog necessary? Denying it does not seem to affect the operation of Teletype.

👋 Hi @jsejcksn: If you're able to click "Deny" and then still share/join a portal, then it sounds like the dialog is unnecessary. We're not intentionally triggering that dialog, so this issue will need additional investigation.

We're heads down on a handful of other priorities at the moment, but if someone wants to offer a pull request to improve this behavior, I'd be happy to offer code review and try to help get the pull request merged.

@jsejcksn
Copy link

I realize this is low priority. Thank you for responding, @jasonrudolph.

@rriemann
Copy link

rriemann commented Apr 1, 2020

I have this issue on Linux. How is this linked to the ssh-agent or ssh-add?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants