This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
RFE: remove pusher.com dependency #393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide before submitting any pull requests.
Requirements
Description of the Change
Updated teletype-server to use different external dependencies. Replaced Twilio with Coturn and Pusher with SocketCluster.
Alternate Designs
SocketCluster could be replaced with a separate library that handles pubSub.
Benefits
It is possible to run teletype-server without having to use external dependencies.
Possible Drawbacks
Verification Process
Ran teletype-server with coturn and socketcluster and verified that atom could establish a shared session.
Applicable Issues
atom/teletype-server#35