Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated environment build #16

Open
FranklinHu1 opened this issue Aug 28, 2024 · 3 comments
Open

Updated environment build #16

FranklinHu1 opened this issue Aug 28, 2024 · 3 comments

Comments

@FranklinHu1
Copy link

Hello,

Thanks for sharing the equiformer repo! I was wondering if there were any efforts towards creating an updated environment yaml file with newer versions of packages like PyTorch? The interface for some of the layers in PyTorch have changed between version 1.10.2 and the most recent version 2.4.0, such as the LayerNorm layer now accepting a keyword bias argument.

Thanks!

@yilunliao
Copy link
Member

Hi @FranklinHu1

Sorry for the late response.

Currently, I am not working on updating the environment.
Is there something specific that you want me to look at so that the codebase can be compatible with newer versions?

@FranklinHu1
Copy link
Author

Hi, sorry for the late response on my part!

Regarding updating the environment, I think that it would just be good to upgrade everything so it works with the newest versions of PyTorch and PyTorch Lightning. We are currently trying to use the Equiformer as part of a larger framework which uses the newer versions of these packages and there have been some incompatibilities, most notably in the interface of layers like LayerNorm.

Thanks!

@yilunliao
Copy link
Member

I see.

If possible, can you share the incompatibilities you have?

I think I will create a new branch and update the PyTorch version there. The main branch would still be the same since we want to make sure there is one copy of code that was used to reproduce the numbers claimed in the paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants