Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk-sync AccessType missing options #83

Open
DGriffin91 opened this issue Aug 28, 2024 · 1 comment
Open

vk-sync AccessType missing options #83

DGriffin91 opened this issue Aug 28, 2024 · 1 comment

Comments

@DGriffin91
Copy link
Contributor

DGriffin91 commented Aug 28, 2024

vk-sync AccessType is missing atomics, consequently requiring the use of AccessType::General. Is this something that should/could be a PR on the expenses/vk-sync-rs repo?
The issue I'm having specifically is with Storage Buffer Atomics.
Actually I see that there isn't an access type for atomics. Need to look into further. Neither read or write was working, but general did. Maybe read/write is needed?

@DGriffin91 DGriffin91 changed the title vk-sync AccessType missing atomics vk-sync AccessType missing options Aug 28, 2024
@attackgoat
Copy link
Owner

Synchronization works at the level of stage and access, where atomic operations like atomicAdd(..) happen within some compute, fragment, etc stage. AccessType::General waits for all stages and ensures all access has completed before allowing additional access - but it should really be for testing only.

Keep in mind that when you declare access in a render graph and then do something, nothing is stopping that operation from running. It's really the next operation when this declared access is used to prevent the second access from interfering with or being affected by the first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants