Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defstruct or maybe cl-defstruct #126

Open
tomnor opened this issue Jul 5, 2020 · 2 comments
Open

defstruct or maybe cl-defstruct #126

tomnor opened this issue Jul 5, 2020 · 2 comments

Comments

@tomnor
Copy link

tomnor commented Jul 5, 2020

Hello Translation hackers

After some package updates and removals, I got an error about `defstruct' being unknown. The following hack got rid of that

diff --git a/google-translate-core-ui.el b/google-translate-core-ui.el
index 2bc4af5..a224f06 100644
--- a/google-translate-core-ui.el
+++ b/google-translate-core-ui.el
@@ -288,2 +288,2 @@ query parameter in HTTP requests.")
 (defvar google-translate-translation-listening-debug nil
   "For debug translation listening purposes.")

-(defstruct gtos
+(cl-defstruct gtos
   "google translate output structure contains miscellaneous
   information which intended to be outputed to the buffer, echo
   area or popup tooltip."

I think defstruct is obsolete but maybe you use that for some backwards reason?

@velkyel
Copy link

velkyel commented Jul 10, 2020

Symbol's function definition is void: defstruct

leuven65 added a commit to leuven65/google-translate that referenced this issue Jul 12, 2020
More fix for atykhonov#126

loop -> cl-loop
incf -> cl-incf
@leuven65
Copy link
Contributor

also need to fix:

  1. loop --> cl-loop
  2. incf --> cl-incf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants