Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching #125

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Caching #125

wants to merge 6 commits into from

Conversation

some-mthfka
Copy link

Caching. Review and testing are advised.

#77

@some-mthfka
Copy link
Author

welp, i don't get why it's failing

not sure how to fix the warnings either

##[warning]The package summary should not end with a period.
[ELISP-CHECK] Running check: elisp-check-checkdoc
[ELISP-CHECK] Checking file: /home/runner/work/google-translate/google-translate/google-translate-cache-ui.el
##[warning]Possibly using local file with different prefix `google-translate-default-ui.el'

@stardiviner
Copy link
Collaborator

welp, i don't get why it's failing

not sure how to fix the warnings either

##[warning]The package summary should not end with a period.
[ELISP-CHECK] Running check: elisp-check-checkdoc
[ELISP-CHECK] Checking file: /home/runner/work/google-translate/google-translate/google-translate-cache-ui.el
##[warning]Possibly using local file with different prefix `google-translate-default-ui.el'

It's just warning from package-lint checking. Warning that elisp file not using filename prefix.

@stardiviner stardiviner requested a review from atykhonov July 12, 2020 00:55
@stardiviner
Copy link
Collaborator

Also, can you write a test for this caching feature?
Thanks for this PR, this PR still need @atykhonov 's reviewing.

@some-mthfka
Copy link
Author

Also, can you write a test for this caching feature?

Sure, added some tests.

@stardiviner
Copy link
Collaborator

@Grigorievich Great that you added test patch. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants