Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corsairlink_commanderpro_set_fan_connection_mode() un-used #240

Open
simplesomeone opened this issue May 15, 2020 · 2 comments
Open

corsairlink_commanderpro_set_fan_connection_mode() un-used #240

simplesomeone opened this issue May 15, 2020 · 2 comments

Comments

@simplesomeone
Copy link

This is more of a question than an actual issue. Why is the corsairlink_commanderpro_set_fan_connection_mode function in https://github.com/audiohacked/OpenCorsairLink/blob/testing/protocol/commanderpro/fan.c#L310 unused?

It seems important. In my specific scenario, we have fans that are coming out as set to "auto" and at 100% PWM, reach 4500RPMs. But the fans are rated for upwards of 12,000RPMs. My suspicion is that it's this mode setting, and it needs to be "4-pin" instead. But this function is not used at all.

Thanks for any help.

@simplesomeone
Copy link
Author

We (my company) has our own fork of this repistory. I added a fan.profile.write_profile driver to run that function with the 0x02 "4-pin" setting. That resolved the issue.

For anyone wondering why your fans are not running at full power, it needs to be 4-pin, not AUTO!

@simplesomeone
Copy link
Author

I guess I'll leave this issue open in case anyone wants to submit an official fix. I unfortunately do not have time at this moment. Maybe in the future I will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants