Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Option to only take into account 'postcontent' #2

Open
ChipsPbx opened this issue Nov 22, 2019 · 1 comment
Open

[Suggestion] Option to only take into account 'postcontent' #2

ChipsPbx opened this issue Nov 22, 2019 · 1 comment

Comments

@ChipsPbx
Copy link

Hi,

It would be great if we could have the option to choose which actual progress the bar displays, between "All the page" (header, content, footer etc...) and "Only content".

If the plugin works wonders on desktop, on responsive mobile it can be misleading because the length of the page can be artificially longer. If for example on mobile your sidebar is displayed after the post content, then the progress bar takes that sidebar into account. Meaning the reader has finished reading the actual content, and yet the progress bar is still at 50 or X%, because of what is still below on the page.

It would be cool to be able to choose what the readers actually read :)

@rgevrek
Copy link

rgevrek commented Aug 9, 2020

Hi,

I have created a pull request for solving this issue: #3

So that if the DOM contains a <main> tag, this will be the reference item for progress, else it uses the whole document as the current case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants