Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt-instr should not leave log.txt in ${PWD} #5

Open
kdudka opened this issue Dec 3, 2021 · 2 comments
Open

sbt-instr should not leave log.txt in ${PWD} #5

kdudka opened this issue Dec 3, 2021 · 2 comments

Comments

@kdudka
Copy link
Contributor

kdudka commented Dec 3, 2021

It breaks the tests/rm/rm3.sh regression test of GNU coreutils:

--- exp 2021-12-03 14:36:22.602444792 +0100
+++ out 2021-12-03 14:36:09.277692425 +0100
@@ -2,6 +2,7 @@
 rm: remove directory 'z'
 rm: remove directory 'z/d'
 rm: remove regular empty file 'z/empty'
+rm: remove regular empty file 'z/log.txt'
 rm: remove symbolic link 'z/slink'
 rm: remove symbolic link 'z/slinkdot'
 rm: remove write-protected directory 'z/du'
@lzaoral lzaoral self-assigned this Dec 8, 2021
@lzaoral
Copy link
Member

lzaoral commented Dec 9, 2021

This is caused by following line in src/instr.cpp:

https://github.com/staticafi/sbt-instrumentation/blob/ccfe9ae8e2ff91fceae94071e2f4cfa4224addee/src/instr.cpp#L52

@kdudka
Copy link
Contributor Author

kdudka commented Dec 9, 2021

If we really need the log, it needs to be created in SYMBIOTIC_CAPTURE_DIR.

lzaoral added a commit that referenced this issue Dec 9, 2021
@lzaoral lzaoral removed their assignment Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants