Use perfect conversion policy in inverse functions #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have constants, we can replace the overflow safety surface heuristic with exact checks. This PR uses constants to do this. It adds a new unit test that would have failed before these implementation changes. It also includes an uncomment-to-check test case which still would fail, as it must. Fixes #190.
chiphogg
added
the
release notes: 🐛 lib (bugfix)
geoffviola
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have constants, we can replace the overflow safety surface
heuristic with exact checks. This PR uses constants to do this. It
adds a new unit test that would have failed before these implementation
changes. It also includes an uncomment-to-check test case which still
would fail, as it must.
Fixes #190.