Removed oss-library-gradle-plugin with maven-publish #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
reviewed
Sep 16, 2024
There was a problem hiding this comment.
❤️ I love getting rid of the plugin, or at least the publishing pieces of it! My only question would be that since we have many java SDKs, it seems like there will be a lot of common build script code replicated across the libraries. Just wondering if there's a way to reuse that code, e.g., maybe in an updated plugin that only has that shared code. But I will let you and the team make that decision 👍
| id 'com.auth0.gradle.oss-library.java' | ||
| id 'me.champeau.gradle.japicmp' version '0.2.9' | ||
| // id 'java-gradle-plugin' | ||
| // id "com.gradle.plugin-publish" version "0.12.0" |
There was a problem hiding this comment.
any reason to keep these commented-out lines?
| } | ||
|
|
||
| repositories { | ||
| // jcenter() | ||
| // google() | ||
| // gradlePluginPortal() |
There was a problem hiding this comment.
can we remove these commented lines?
|
This PR is not being used. Refer - #665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
References
Please include relevant links supporting this change such as a: